Make tentative approvals less obtrusive - #859
Merged
Merged
Conversation
Merged
Sakib25800
approved these changes
Sep 25, 2026
| // If we are now doing a tentative approval, we will "upgrade" it to a full approval, which is | ||
| // usually what the user wants. | ||
| // This situation should be very rare anyway. | ||
| let pr_ci_status = get_pr_ci_status(&repo, pr.github).await?; |
Member
There was a problem hiding this comment.
If this request fails, we lose the approval. Maybe we should handle this?
Member
Author
There was a problem hiding this comment.
It would abort the approval, but we do this GitHub API request proactively, before we record the approval in the DB, so it shouldn't matter much. We already do at least one other GitHub API call before this (fetching the PR from GitHub), and a bunch of DB calls. Aborting if a network request fails is kind of a normal operation in bors, and there's not much to do here instead anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes tentative approvals be less "in your face". When a PR is tentatively approved, bors sends a comment that the PR was approved, or tentatively approved. It then won't send another comment once PR CI actually succeeds (this event is now silent), unlike before.
Funnily enough, this actually simplifies the "frontend" implementation of tentative approvals quite a lot.
Discussed in https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/bors.20r.2B.20after.20pr.20ci.20passes/with/626795222.